Allow editing of params at any time #30939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebullient
approved these changes
Feb 7, 2023
geoand
approved these changes
Feb 7, 2023
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
force-pushed
the
edit-cli-any-time
branch
from
65cf36a to
664f048
Compare
This comment has been minimized.
This comment has been minimized.
|
@stuartwdouglas .. does this one just need a rebase? Did you have any other reservations about merging it? |
stuartwdouglas
force-pushed
the
edit-cli-any-time
branch
from
664f048 to
d11ec54
Compare
|
I have rebased, but looking at the test results it must be somehow screwing with the remote dev tests. |
This comment has been minimized.
This comment has been minimized.
stuartwdouglas
force-pushed
the
edit-cli-any-time
branch
from
d11ec54 to
b84bbe9
Compare
This comment has been minimized.
This comment has been minimized.
Currently it is only possible to edit command line parameters in dev mode after the application has exited. This means that if you have long running applications (or accidently hang your app) you can't restart with different parameters.
stuartwdouglas
force-pushed
the
edit-cli-any-time
branch
from
b84bbe9 to
a830a0c
Compare
ebullient
approved these changes
May 23, 2023
|
✔️ The latest workflow run for the pull request has completed successfully. It should be safe to merge provided you have a look at the other checks in the summary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is only possible to edit command line parameters in dev mode after the application has exited. This means that if you have long running applications (or accidently hang your app) you can't restart with different parameters.